Draft
Conversation
glomdom
added
enhancement
…egments for primitives
only `int` is supported for now, but new types can be easily added, so this is not an issue until regression tests are fixed
glomdom
force-pushed
the
feat/span-reading
branch
from
8e1dfa0 to
0f42398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize reading method to a segmenting approach. Separate const-sized fields into constant segments where we can determine the size of bytes required to read, allowing us to use a single I/O call to read into a buffer, and use
Spanslicing to assign the fields. For dynamic-sized fields, such as arrays with no provided const size, use a dynamic segment with anArrayPoolof bytes, allowing reuse of the buffer.