Add command line options for glj -e --version --help -h #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI tests require 'bin/<os-arch>/glc' binary to be built in order to run 'glj ...' commands and test the output.
jfhamlin
approved these changes
Aug 11, 2025
Contributor
jfhamlin
left a comment
jfhamlin
left a comment
There was a problem hiding this comment.
great start on a more featureful CLI!
Comment on lines
+19
to
+26
| (defn run-cli-cmd [& args] | ||
| (let [bytes-to-string (fn [bytes] | ||
| (if (nil? bytes) | ||
| "" | ||
| (apply str (map char (seq bytes))))) | ||
| cmd (apply os$exec.Command args) | ||
| [output err] (.CombinedOutput cmd)] | ||
| [(bytes-to-string output) (bytes-to-string err)])) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started by adding
glj -e ...support. Much likebb -e ...orcj -M -e ....Added
*glojure-version*variable support.This supports
glj --version.Added
--helpand-hfor good measure.CLI tests for all.
Had to adjust Makefile to build
bin/.../gljbinary to test stdout of CLI commands.Added
buildandcleanMakefile targets to be complete.