Skip to content

Skip system-dependent number tests #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfhamlin merged 1 commit into from
Aug 3, 2025
Merged

Skip system-dependent number tests #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions test/glojure/test_glojure/numbers.glj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,18 +142,21 @@
[
[:input [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 math.MaxInt64 math.MaxFloat32 math.MaxFloat64]]
[char [:error (char 0) (char 1) (char 127) (char 32767) :error :error :error :error]]
;; In go, char == rune, which is equivalent to int32
[unchecked-char [(Char -1) (Char 0) (Char 1) (Char 127) (Char 32767) (Char math.MaxInt32) (Char -1) (Char -1) (Char -1)]]
;; In go, char == rune, which is equivalent to int32 ;; system-dependent
[unchecked-char [(Char -1) (Char 0) (Char 1) (Char 127) (Char 32767) (Char math.MaxInt32) (Char -1) :skip :skip]]
;; bytes are unsigned in go
[byte [255 0 1 math.MaxInt8 :error :error :error :error :error]]
;; bytes are unsigned in go
[unchecked-byte [255 0 1 math.MaxInt8 255 255 255 255 255]]
;; bytes are unsigned in go ;; system-dependent
[unchecked-byte [255 0 1 math.MaxInt8 255 255 255 :skip :skip]]
[short [-1 0 1 math.MaxInt8 math.MaxInt16 :error :error :error :error]]
[unchecked-short [-1 0 1 math.MaxInt8 math.MaxInt16 -1 -1 -1 -1]]
;; ;; system-dependent
[unchecked-short [-1 0 1 math.MaxInt8 math.MaxInt16 -1 -1 :skip :skip]]
[int [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 max-int-res :error :error]]
[unchecked-int [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 max-int-res max-int-res max-int-res]]
;; ;; system-dependent
[unchecked-int [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 max-int-res :skip :skip]]
[long [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 math.MaxInt64 :error :error]]
[unchecked-long [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 math.MaxInt64 math.MaxInt64 math.MaxInt64]]
;; ;; system-dependent
[unchecked-long [-1 0 1 math.MaxInt8 math.MaxInt16 math.MaxInt32 math.MaxInt64 :skip :skip]]
;; 2.14748365E9 if when float/double conversion is avoided...
[float [-1.0 0.0 1.0 127.0 32767.0 2.147483648E9 9.223372036854776E18 math.MaxFloat32 :error]]
[unchecked-float [-1.0 0.0 1.0 127.0 32767.0 2.147483648E9 9.223372036854776E18 math.MaxFloat32 (go/float32 (math.Inf 1))]]
Expand All @@ -163,11 +166,13 @@
(deftest test-expected-casts
(let [[[_ inputs] & expectations] expected-casts]
(doseq [[f vals] expectations]
(let [wrapped (fn [x]
(try
(f x)
(catch go/any e :error)))]
(is (= vals (map wrapped inputs)))))))
(let [wrapped (fn [x expected]
(if (= expected :skip)
expected
(try
(f x)
(catch go/any e :error))))]
(is (= vals (map wrapped inputs vals)))))))

(deftest test-prim-with-matching-hint
(is (= 1.0 (let [x 1.2] (math.Round ^go/float64 x)))))
Expand Down