FIX - Crash - faustexception - on linux #9#10
Open
jdsierral wants to merge 11 commits intoglocq:masterfrom
Open
FIX - Crash - faustexception - on linux #9#10jdsierral wants to merge 11 commits intoglocq:masterfrom
jdsierral wants to merge 11 commits intoglocq:masterfrom
Conversation
…y for XCode and VS)
- Suggested use of modern smart pointers (eg. std::unique_ptr) in favor of using new whenever possible. A side effect of this is that destructors are no longer needed in most cases. - Removed empty destructors... in general if a destructor or even a constructor is not needed it is not usually considered best practice to declare it empty. In particular with destructors there are RAII principles that suggest that declaring a destructor implies that copy and move operators should also be declared (Rule of three) - Removed unnecessary semicolons in function definitions... these are only required if we only provide a declaration - Added override in a couple missing places where a function was shadowing the super class implementation No functionality was modified with these changes
- Suggested use of modern smart pointers (eg. std::unique_ptr) in favor of using new whenever possible. A side effect of this is that destructors are no longer needed in most cases. - Removed empty destructors... in general if a destructor or even a constructor is not needed it is not usually considered best practice to declare it empty. In particular with destructors there are RAII principles that suggest that declaring a destructor implies that copy and move operators should also be declared (Rule of three) - Removed unnecessary semicolons in function definitions... these are only required if we only provide a declaration - Added override in a couple missing places where a function was shadowing the super class implementation No functionality was modified with these changes
Owner
|
Welp. I have an issue, but I think it dates back to your earlier pull request. We should have tested seriously. The issue is: I tried some code with a parameter, but moving the slider doesn't change the parameter. I tried to see what commit introduced the issue, it seems to be the "general code review", but it's hard to be sure because of all the merges that happen afterwards (I'm still trying to get to grips with merges in git). I think I will go back to before your code review, and try to introduce the changes one by one with appropriate testing at each step. Three remarks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heres my attempt to fix that bug :)... lets see how it goes :)...
I removed the smart pointer and used nullptr instead of argv... tested it and was working on osx... not extensive testing though