Open
Conversation
NickolausDS
force-pushed
the
integration-tests
branch
from
0811896 to
05f1062
Compare
Contributor
Author
This should be good to go unless we find new test cases. It takes about a minute to run the current set of tests, and it's pretty easy to add new ones if there's anything more we want to try.
|
banubot
reviewed
Aug 1, 2025
gladier_xpcs/deployments.py
Outdated
| voyager8IDI = SharedCollection('dc86d51b-81d1-4827-81be-2b5e64ba7dc1', | ||
| '/gdata/dm/8IDI/', name='APS:DM:8IDI Guest') | ||
| voyager8IDI = SharedCollection('aa2b18e8-e248-4265-985c-7e2e59765539', | ||
| '/gdata/dm/', name='APS:DM:8IDI Guest') |
Collaborator
There was a problem hiding this comment.
Path for this collection ID is /gdata/dm/8ID and collection name is APS:DM:8ID Guest
ryanchard
approved these changes
Aug 7, 2025
Contributor
ryanchard
left a comment
ryanchard
left a comment
There was a problem hiding this comment.
These tests will be very helpful. Once this is merged we should consider whether there are other tests we need to add. I believe last week's experiment used a different detector or approach? Timepix? But we shouldn't hold this up for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some integration tests written in pytest for running a handful of live XPCS datasets in parallel to make sure that all datasets perform well in corr. When run on the command line, results in the following:
[gw2] [ 25%] PASSED tests/integration/test_datasets.py::test_datasets[Eiger4m -- Multitau]
[gw1] [ 50%] PASSED tests/integration/test_datasets.py::test_datasets[Rigaku3m -- Twotime]
[gw3] [ 75%] PASSED tests/integration/test_datasets.py::test_datasets[Eiger4m -- Twotime]
[gw0] [100%] PASSED tests/integration/test_datasets.py::test_datasets[Rigaku3m -- Multitau]
Instructions are in tests/integration/readme.md
I still need feedback from Suresh/Miaoqi on which datasets are the best for testing these.