Check for uri in segment key before creating class#41
Open
GreenZapdos wants to merge 1 commit intoglobocom:masterfrom
Open
Check for uri in segment key before creating class#41GreenZapdos wants to merge 1 commit intoglobocom:masterfrom
GreenZapdos wants to merge 1 commit intoglobocom:masterfrom
Conversation
Contributor
|
@GreenZapdos can you add tests and an example playlist so we can understand better your pull request? |
Author
|
The current version of m3u8 (0.2.4) will not load a playlist like this: #EXTM3U
#EXT-X-KEY:METHOD=AES-128,URI="http://example.com/key1",IV=0x01
#EXTINF:10,
http://example.com/video/encrypted-1.ts
#EXT-X-KEY:METHOD=AES-128,URI="http://example.com/key2",IV=0x02
#EXTINF:10,
http://example.com/video/encrypted-2.ts
#EXT-X-KEY:METHOD=AES-128,URI="http://example.com/key3",IV=0x03
#EXTINF:10,
http://example.com/video/encrypted-3.ts
#EXT-X-KEY:METHOD=UNENCRYPTED
#EXTINF:10,
http://example.com/video/unencrypted-A.tsI'm not sure how this should be tested. |
Contributor
|
@GreenZapdos I think you can inspire by looking at https://github.com/globocom/m3u8/blob/master/tests/test_parser.py#L10 but instead of a |
Contributor
|
@GreenZapdos ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some m3u8 servers, there is an #EXT-X-KEY line without a uri to signify that there is not a key.