Support extra EXT-OATCLS-SCTE35 tags during CUE-OUT#398
Closed
bbayles wants to merge 2 commits intoglobocom:masterfrom
Closed
Support extra EXT-OATCLS-SCTE35 tags during CUE-OUT#398bbayles wants to merge 2 commits intoglobocom:masterfrom
bbayles wants to merge 2 commits intoglobocom:masterfrom
Conversation
wurlced
approved these changes
Jun 6, 2025
Contributor
Author
|
Checking in on this - I'm seeing playlists that need this modified behavior in the wild, hence my change request here. Thanks! |
Contributor
Author
|
Withdrawing - I found more cases to support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates handling for the
EXT-OATCLS-SCTE35. These are used in the "Elemental" style playlists that are supported by this library.One subtlety that the library currently doesn't capture is that a segment can signal things like "program end" during a "cue out" interval. Below is a playlist from an Elemental service that shows this in action - the initial
OATCLSmessage is repeated until a new explicit one is inserted.I've updated the test case to capture this behavior.