Conversation
mauricioabreu
approved these changes
Nov 9, 2024
Contributor
mauricioabreu
left a comment
mauricioabreu
left a comment
There was a problem hiding this comment.
Amazing, thank you!
| os.makedirs(basename, exist_ok=True) | ||
|
|
||
|
|
||
| T = TypeVar("T") |
Contributor
Author
There was a problem hiding this comment.
daveisfera
force-pushed
the
list_typing
branch
from
e84d6f3 to
e30b06e
Compare
Contributor
Author
|
Rebased and ready to merge |
daveisfera
force-pushed
the
list_typing
branch
from
e30b06e to
ce50cca
Compare
Contributor
Author
|
Any chance we could get this merged and released? Would love to have the typing improvements in my IDE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is using
Listfromtypingbut once #391 is merged, I can rebase this and just uselist