chore: add localstack S3 to docker compose#145
chore: add localstack S3 to docker compose#145arrocke merged 2 commits intoglobalbibletools:mainfrom
Conversation
arrocke
left a comment
arrocke
left a comment
There was a problem hiding this comment.
Thanks so much for working on this! I left a couple of suggestions to streamline the config and setup
| env_file: | ||
| - path: .env | ||
| required: false | ||
| localstack: |
There was a problem hiding this comment.
Looks like when using docker compose, we need to mount a volume for all localstack data otherwise the system state will be lost. Let's mount ./localstack/data to /var/lib/localstack and add that file to gitignore.
compose.yaml
Outdated
| - path: .env | ||
| required: false | ||
| localstack: | ||
| image: localstack/localstack:latest |
There was a problem hiding this comment.
If there is a way to pin this to at least a major version, that would prevent changes to localstack from accidentally breaking our dev environements
compose.yaml
Outdated
| timeout: 5s | ||
| retries: 5 | ||
|
|
||
| localstack-init: |
There was a problem hiding this comment.
We should be able to avoid an additional container just for running scripts by useing initialization hooks. We can mount "./localstack/init/" to "/etc/localstack/init/" and then add the init script to ./localstack/init/ready.d/init.sh. That script can use awslocal instead of aws since that's loaded on the container already.
We will likely need to add more things to the init script, so having that as its own file makes that easier to edit and review.
arrocke
left a comment
arrocke
left a comment
There was a problem hiding this comment.
🎉 Looks great! Thanks for working on this!
2 participants
Split from: #134
Adds a LocalStack S3 service to docker compose so export storage can be exercised locally; this is purely infrastructure wiring.