Open
Conversation
Member
|
I took a quick look and it looks right. @amazingsmash can you check it too? |
Contributor
|
I haven't tested either but all changes seem logic. Native implementation of GL seems complete. |
Member
|
I took a quick overview, and it looks right. BTW, I'd like to remove the GL:: uploadTexture() method without the wrap parameter, and refactor all over around where this method is called. In short, I don't think that any wrap policy could be the default and it has to be set explicitly in all calls to uploadTexture(). @amazingsmash do you agree? |
Contributor
|
I've already removed those methods, and added a little example over the Gran Canaria island of a repeated texture. |
added 2 commits
February 20, 2016 17:30
Member
|
@amazingsmash I can't believe my eyes, you're working on Saturday! =o) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to use textures with
GL_REPEATinstead ofGL_CLAMP_TO_EDGEwrap mode.In this code version
TexturesHandlerhas a newgetTextureIDReferencemethod with an additional parameter to control wrap mode.