Skip to content

Aeroglass glrepeat support clean#170

Open
zoltanpillio wants to merge 16 commits intopurgatoryfrom
aeroglass-glrepeat-support-clean
Open

Aeroglass glrepeat support clean#170
zoltanpillio wants to merge 16 commits intopurgatoryfrom
aeroglass-glrepeat-support-clean

Conversation

@zoltanpillio
Copy link

We would like to use textures with GL_REPEAT instead of GL_CLAMP_TO_EDGE wrap mode.
In this code version TexturesHandler has a new getTextureIDReference method with an additional parameter to control wrap mode.

@DiegoGomezDeck
Copy link
Member

I took a quick look and it looks right. @amazingsmash can you check it too?

@amazingsmash
Copy link
Contributor

I haven't tested either but all changes seem logic. Native implementation of GL seems complete.

@DiegoGomezDeck
Copy link
Member

I took a quick overview, and it looks right.

BTW, I'd like to remove the GL:: uploadTexture() method without the wrap parameter, and refactor all over around where this method is called. In short, I don't think that any wrap policy could be the default and it has to be set explicitly in all calls to uploadTexture().

@amazingsmash do you agree?

@amazingsmash
Copy link
Contributor

I've already removed those methods, and added a little example over the Gran Canaria island of a repeated texture.

@DiegoGomezDeck
Copy link
Member

@amazingsmash I can't believe my eyes, you're working on Saturday! =o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants