Weak type check broke URLs that ended in "#0"#26
Open
techteam-seobility wants to merge 1 commit intoglenscott:masterfrom
Open
Weak type check broke URLs that ended in "#0"#26techteam-seobility wants to merge 1 commit intoglenscott:masterfrom
techteam-seobility wants to merge 1 commit intoglenscott:masterfrom
Conversation
If the fragment entity is exactly string "0", as if the URL http://example.com/#0 is passed to the method the if statment in Line 236 will return false even tough it should not an the returned URL will be http://example.com/0 which is false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the fragment entity is exactly string "0", as if the URL http://example.com/#0 is passed to the method the if statment in Line 236 will return false even tough it should not an the returned URL will be http://example.com/0 which is incorrect.