feat: add Dockerfile for local-mcp-server#288
Closed
ivanilves wants to merge 7 commits intogleanwork:mainfrom
Closed
feat: add Dockerfile for local-mcp-server#288ivanilves wants to merge 7 commits intogleanwork:mainfrom
ivanilves wants to merge 7 commits intogleanwork:mainfrom
Conversation
Member
rwjblue-glean
left a comment
There was a problem hiding this comment.
Overall, this seems good! Can you throw together a basic github actions workflow that ensures the Dockerfile continues to work?
Ensures the Dockerfile continues to work by building and verifying the image on every PR and push to main.
Author
|
@rwjblue-glean Done! I've added a minimal GitHub Actions workflow ( The workflow:
Sorry for such a delay in update 🙏 Please tell me if it's enough. |
Contributor
|
Hi there! Thanks for all your work on this. You actually inspired us to just go ahead and implement this ourselves rather than continuing with the back-and-forth and using up more of your time. I'm gonna close this PR in favor #311 but please do take a look and let us know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Dockerfile for the Glean
local-mcp-serverto enable containerized deployment. This allows users and developers to easily build and run the MCP server in a consistent Docker environment without local Node.js setup requirements.Related Issue
Related to #106
Motivation and Context
To enable containerized deployment of the Glean local MCP server, providing:
Type of Change
How Has This Been Tested?
docker build -t glean-mcp-server .Additional Notes
This is a non-breaking addition that:
Build command:
docker build -t glean-mcp-server .