Merged
Conversation
priv/styles/main.css
Outdated
| overflow-y: auto; | ||
| max-height: 90vh; | ||
| border-radius: .4rem; | ||
| max-height: calc(100svh - 32px); /* 16px from top and bottom */ |
Member
There was a problem hiding this comment.
Wouldn't it be better to use dvh so it always looks good both in both viewport configurations rather than just one of the two?
- Using dvh:
- Using svh:
Member
Author
|
Have made a couple of fixes here now - the borders for the items in the table of contents would occasionally break because I implemented it in a very silly way. Before: After: Thanks, pseudo elements. This also fixes the sidebar height to be consistently spaced from the top and bottom of the page, regardless of screen size. Thanks to @giacomocavalieri for pointing out using dvh to achieve it! |
Member
|
ah! merge conflict! |
Fixes some padding that was far too small, and the sidebar border being broken up by long section titles.
thanks Jak!
Member
Author
|
Should be fixed now - had to do a janky force push because I forgot GitHub's web view adds a merge commit 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some padding that was far too small, and the sidebar border being broken up by long section titles.
I also ran my CSS formatter on save but would like to stick with that in the future if possible - this might be the wrong place to shoehorn that in, though.