Open
Conversation
Adds configurable limits for binary input size and auditable payload size to avoid OOM risks when scanning binaries.
Avoids a semver-breaking change to AuditConfig by applying binary scan limits directly on the auditor. Adds a default 100MB input cap (0 disables) and supports overriding the auditable payload limit.
Add a regression test which ensures `cargo audit bin --max-binary-size` rejects oversized inputs.
|
You filed this against your fork. If you intend to upstream these changes, you'll want to submit a PR against the upstream repo. Please squash all your commits before doing so. |
Owner
Author
|
Thanks! I’ve upstreamed this as a single squashed commit PR: rustsec#1516 (rustsec#1516). I’ll follow up there going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! My name is Gabriel, and I’m interested in the RustSec project and have been digging into binary scanning limits.
Related upstream issue: rustsec#740
Summary
cargo audit binCLI flags for max input binary size and auditable payload sizeTest plan