Skip to content

gh-783: Write PR comment if regression test workflow fails #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connoraird wants to merge 3 commits into from
Closed

gh-783: Write PR comment if regression test workflow fails #787

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e0d06f
Write PR comment if regression test workflow fails
connoraird Nov 13, 2025
0529911
Don't fail job if regression test fails
connoraird Nov 13, 2025
75a8e34
double escape in workflow
connoraird Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/workflows/regression-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ on:
- reopened
- synchronize

env:
REGRESSION_TEST_OUTPUT_FILE: output.txt

jobs:
regression-tests:
if: github.event.pull_request.draft == false
Expand Down Expand Up @@ -52,10 +55,30 @@ jobs:
run: uv sync --only-dev

- name: Run regression test
continue-on-error: true
run: >-
uv run nox -s regression_tests-${{ matrix.python-version }} --
"$BASE_REF" "$HEAD_REF"
"${BASE_REF}" "${HEAD_REF}" | tee ${REGRESSION_TEST_OUTPUT_FILE}
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
HEAD_REF: ${{ github.event.pull_request.head.ref }}
FORCE_COLOR: 1

- name: Extract regression information for PR comment
id: extract_comment
if: failure()
run: >-
f=${REGRESSION_TEST_OUTPUT_FILE}; start=$(grep -n -m1 'Performance has
regressed:' "${f}" | cut -d: -f1)
|| { echo "No match"; exit 1; };
s_dash=$(awk -v n=${start} 'NR<=n && /^-+$/ {l=NR} END{print l}'
"${f}"); e_dash=$(awk -v n=${start} 'NR>=n && /^-+$/ {print NR; exit}'
"${f}"); PR_COMMENT_MSG=$(sed -n "${s_dash},${e_dash}p" "${f}"); echo
"PR_COMMENT_MSG=${PR_COMMENT_MSG}" >> ${GITHUB_OUTPUT};

- name: Write PR comment
if: failure()
uses: mshick/add-pr-comment@v2
with:
message: >-
${{ steps.extract_comment.outputs.PR_COMMENT_MSG }}
Loading