Skip to content

Conversation

@connoraird
Copy link
Contributor

Description

Migrated over from glass-dev/glass-benchmarks#16

Adding benchmarks for glass.algorithm functions. Mostly these benchmarks are copies of the tests that exist in glass already. However, I have removed sad paths tests which exit early as I believe these are not as relevant for testing the performance of these functions in a working state.

There is still work to be done for benchmarking glass.algorithm.nnls as this is not fully covered. Should be handled in #759

Closes: #758

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@connoraird connoraird self-assigned this Nov 13, 2025
@connoraird connoraird added the benchmarks Benchmarking work label Nov 13, 2025
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back tests

@connoraird connoraird merged commit b059343 into main Nov 13, 2025
17 checks passed
@connoraird connoraird deleted the connor/issue-758 branch November 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Benchmarking work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add benchmarks for algorithm.py

3 participants