Skip to content

gh-977: Actually test deprecated fields.py functions #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paddyroddy merged 3 commits into from
Jan 29, 2026
Merged

gh-977: Actually test deprecated fields.py functions #1033

paddyroddy merged 3 commits into from
Jan 29, 2026

Conversation

@connoraird
Copy link
Contributor

@connoraird connoraird commented Jan 29, 2026 •
edited
Loading

Description

The deprecated functions in fields.py weren't actually being tested as their generators needed to be consumed. This PR...

Refs: #977

Changelog entry

Fixed: Incomplete support for the array api of glass.generate is now fixed.

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@connoraird connoraird requested a review from paddyroddy January 29, 2026 17:01
@connoraird connoraird self-assigned this Jan 29, 2026
@connoraird connoraird added the array-api Work is related to the Array API label Jan 29, 2026
@connoraird connoraird changed the title Actually test deprecated fields.py functions gh:-977: Actually test deprecated fields.py functions Jan 29, 2026
@connoraird connoraird changed the title gh:-977: Actually test deprecated fields.py functions gh-977: Actually test deprecated fields.py functions Jan 29, 2026
@connoraird connoraird marked this pull request as ready for review January 29, 2026 17:04
paddyroddy
paddyroddy reviewed Jan 29, 2026
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@paddyroddy paddyroddy self-requested a review January 29, 2026 17:15
@paddyroddy paddyroddy merged commit 78005f2 into main Jan 29, 2026
11 of 14 checks passed
@paddyroddy paddyroddy deleted the connor/test-deprecated-functions branch January 29, 2026 17:16
@connoraird
Copy link
Contributor Author

connoraird commented Jan 29, 2026

Performance regressed

--------------------------------------------------------------------------------
Performance has regressed:
	test_generate[numpy-None] (0001_ae31aa0) - Field 'mean' has failed PercentageRegressionCheck: 6.477535294 > 5.000000000
	test_generate[numpy-1] (0001_ae31aa0) - Field 'mean' has failed PercentageRegressionCheck: 24.129720471 > 5.000000000
--------------------------------------------------------------------------------

@paddyroddy
Copy link
Member

paddyroddy commented Jan 29, 2026

Performance regressed

--------------------------------------------------------------------------------
Performance has regressed:
	test_generate[numpy-None] (0001_ae31aa0) - Field 'mean' has failed PercentageRegressionCheck: 6.477535294 > 5.000000000
	test_generate[numpy-1] (0001_ae31aa0) - Field 'mean' has failed PercentageRegressionCheck: 24.129720471 > 5.000000000
--------------------------------------------------------------------------------

But now actually Array API compatible? Can you check this in conjunction with #979?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paddyroddy paddyroddy paddyroddy approved these changes

Assignees

@connoraird connoraird

Labels

array-api Work is related to the Array API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connoraird @paddyroddy