-
Notifications
You must be signed in to change notification settings - Fork 12
gh-998: Change all references to len to .shape[0]
#1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
len to .shape[0]len to .shape[0]
connoraird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that the instances of size which are now shape[0] used to be len or are being applied to a cl?
See 6a12b05 |
So are we not sure if they used to be |
I wasn't clear what you were asking. I guess not. |
If we trust our tests then this is okay |
I probably don't... Will check tomorrow. |
I've been more cautious and reverted all of them unless |
Description
The Array API spec doesn't have a definition of
len(). This PR changes.sizereferences to.shape[0]. It also changes some currentlen()to.shape[0].Closes: #998
Checks