Skip to content

Conversation

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Jan 26, 2026

Description

  • Sorted conftest imports
  • Cleared out benchmarks pytest.skip
  • Consistent pytest.skip

Closes: #1000

Refs: #902

Changelog entry

Changed: _generate_grf is now compatible with the Array API

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy self-assigned this Jan 26, 2026
@paddyroddy paddyroddy added the array-api Work is related to the Array API label Jan 26, 2026
@paddyroddy paddyroddy requested a review from connoraird January 26, 2026 15:26
@paddyroddy
Copy link
Member Author

Test failure is something GHA related

@paddyroddy
Copy link
Member Author

@connoraird, thoughts?

test_generate[numpy-None] (0001_39d6123) - Field 'mean' has failed PercentageRegressionCheck: 29.183546167 > 5.000000000
test_generate[numpy-1] (0001_39d6123) - Field 'mean' has failed PercentageRegressionCheck: 66.193119934 > 5.000000000

@paddyroddy paddyroddy added the needs-2-reviewers Could be considered "controversial" so worth a second pair of eyes label Jan 26, 2026
@paddyroddy paddyroddy requested a review from ntessore January 26, 2026 17:10
@connoraird
Copy link
Contributor

Sorry, I didn't realise this was being done. I have also done this in #979. There is only one difference between the two approaches. I calculate the size of z only once to try to improve performance.

@paddyroddy
Copy link
Member Author

Sorry, I didn't realise this was being done. I have also done this in #979. There is only one difference between the two approaches. I calculate the size of z only once to try to improve performance.

I did say I would move it out of #963 when you reviewed it... There's some other stuff I want in. But that can be done separately.

@paddyroddy paddyroddy changed the base branch from main to connor/issue-977 January 29, 2026 10:53
@paddyroddy paddyroddy changed the title gh-1000: port _generate_grf gh-1000: Remove conftest imports and consistent pytest.skip Jan 29, 2026
Copy link
Contributor

@connoraird connoraird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spots

@paddyroddy paddyroddy merged commit 690182c into connor/issue-977 Jan 29, 2026
23 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-1000 branch January 29, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

array-api Work is related to the Array API needs-2-reviewers Could be considered "controversial" so worth a second pair of eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port _generate_grf

3 participants