-
Notifications
You must be signed in to change notification settings - Fork 12
gh-1000: Remove conftest imports and consistent pytest.skip
#1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test failure is something GHA related |
|
@connoraird, thoughts? |
|
Sorry, I didn't realise this was being done. I have also done this in #979. There is only one difference between the two approaches. I calculate the size of z only once to try to improve performance. |
I did say I would move it out of #963 when you reviewed it... There's some other stuff I want in. But that can be done separately. |
_generate_grfconftest imports and consistent pytest.skip
connoraird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spots
Description
conftestimportspytest.skippytest.skipCloses: #1000
Refs: #902
Changelog entry
Changed:
_generate_grfis now compatible with the Array APIChecks