This repository was archived by the owner on Nov 13, 2025. It is now read-only.
Generate coverage report of glass repo #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single backslash is for latex commands, double backslash is for newline. Closes: #352
Adding `mypy` to a pre-existing codebase is never easy. I initially attempted this in #308, but have since split this up into separate issues: - [x] #347 - [x] #356 - [ ] #358 In this PR, `mypy` is added but in order for CI to pass, the `# type: ignore[]` syntax is used throughout. I didn't want to tackle these here too (see #308) as it gets quite messy. One thing I have done (following #356) is change every empty `npt.NDArray` to `npt.NDArray[typing.Any]` (see #330), as this actually results in fewer errors than leaving them all blank. Ideally, we'd like to fill in as many of the `typing.Any` as possible - they're a bit useless by themselves. However, that is not the priority for now. Plus, I expect typing to change when #67 is tackled.
Fixed: - missing-trailing-comma - commented-out-code - single-line-implicit-string-concatenation - numpy-legacy-random - pytest-raises-too-broad Refs: #248
Increase the tolerance for the test to pass always. Closes: #363
Adds a `.cff` file and moves the `bib` entry to README. Closes: #175 Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
This popped up while I was looking to add tests for `fields.py`. - rename `gaussian_gls` to `discretized_cls` - update docstring and internal references - don't use `gaussian_gls` in `lognormal_gls` Closes: #131 Changed: `gaussian_gls` has been renamed to `discretized_cls` Changed: `lognormal_gls` no longer uses `gaussian_gls` internally and the arguments passed to `gaussian_gls` have been removed Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
The ia_nla function computes the effective convergence from intrinsic alignments, calculated using the Non-linear Aligments Model (NLA). The convergence from intrinsic aligments is follows Catelan et al. (2000), Hirata & Seljak (2004), Bridle & King (2007). Added: The new `kappa_ia_nla()` function computes an effective convergence due to Intrinsic Alignments using the NLA model. Reviewed-by: Nicolas Tessore Reviewed-by: Arthur Loureiro <arthur.loureiro@fysik.su.se> --------- Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk> Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
The coverage went down when branch coverage was turned on. This PR brings it back to 100% for these two files. Refs: #161 Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
…(#371) Rerun the flaky test if it fails. See glass-dev/glass#364 (comment) Closes: #363
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com> Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
This is the release PR for v2024.2. Closes: #390
Member
|
Closing in favour of glass-dev/glass#769 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a coverage report of the glass repo from the benchmarks in this repo