Fixed mate eval if maximize = False#57
Open
NicolasMahn wants to merge 1 commit intogkhayes:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised that if maximize is set to false meaning the fitness values are negative.
The lower fitness values (the fitness values with a higher number but lower value) would still be prefered in procreation as the eval would only consider the size of the number but not it's value. In essence it would ignore the negativity of the fitness values.
This branch proposes a fix.
find in code:
opt_probs.py line 102-116
find new test:
test_opt_probs.py line 151-168
(had to fix the six problem so I could run the tests)