Skip to content

Conversation

@gjong
Copy link
Owner

@gjong gjong commented Jan 16, 2025

Proposed change

Add new sensors for:

  • month peak power as well as the time it was measured
  • average power during the tarif

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the application)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

gjong added 2 commits January 16, 2025 12:58
Previously, the code did not account for cases where 'pts' might be non-existent or zero, potentially causing errors. This update ensures that 'MONTH_PEAK_TIME' is only parsed if 'pts' exists and is greater than zero, improving error handling.
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.37%. Comparing base (c8472c4) to head (5ec253c).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   93.11%   93.37%   +0.26%     
==========================================
  Files          10       10              
  Lines         421      438      +17     
==========================================
+ Hits          392      409      +17     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gjong gjong merged commit 5f95fdb into master Jan 16, 2025
7 checks passed
@gjong gjong deleted the feature/add-peak-power branch January 16, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants