Skip to content

Bump golang.org/x/oauth2 from 0.0.0-20220223155221-ee480838109b to 0.27.0 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjkim42 merged 1 commit into from
Jul 18, 2025
Merged

Bump golang.org/x/oauth2 from 0.0.0-20220223155221-ee480838109b to 0.27.0 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
pull_request:

env:
GO_VERSION: '1.19.2'
GO_VERSION: '1.24.5'
Copy link

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI Go version (1.24.5) is newer than the go.mod version (1.23.0), which could lead to inconsistent behavior between local development and CI. Consider aligning these versions or using the go.mod version in CI.

Suggested change
GO_VERSION: '1.24.5'
GO_VERSION: '1.23.0'

Copilot uses AI. Check for mistakes.
Copy link
Owner

@gjkim42 gjkim42 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot
go version of go.mod means the code uses go 1.23.0 syntax, and go ensures backward compatibility.
Isn't it ok to use a higher version of go?


jobs:
verify:
Expand Down
5 changes: 2 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/gjkim42/default-imagepullsecrets

go 1.19
go 1.23.0
Copy link

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go version in go.mod is set to 1.23.0, but the CI workflow uses Go 1.24.5. This version mismatch could lead to inconsistent behavior between local development and CI environments. Consider aligning both versions.

Suggested change
go 1.23.0
go 1.24.5

Copilot uses AI. Check for mistakes.

require (
github.com/go-logr/logr v1.2.4
Expand Down Expand Up @@ -37,13 +37,12 @@ require (
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/spf13/pflag v1.0.5 // indirect
golang.org/x/net v0.36.0 // indirect
golang.org/x/oauth2 v0.0.0-20220223155221-ee480838109b // indirect
golang.org/x/oauth2 v0.27.0 // indirect
golang.org/x/sys v0.30.0 // indirect
golang.org/x/term v0.29.0 // indirect
golang.org/x/text v0.22.0 // indirect
golang.org/x/time v0.0.0-20220210224613-90d013bbcef8 // indirect
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/protobuf v1.33.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
Expand Down
Loading
Loading