Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-66
to
+71
| seconds = 0 | ||
| for period, multiplier in zip(map(int, time_strs), | ||
| [1, 60, 3600, 24*3600]): | ||
| seconds += period*multiplier | ||
| return seconds | ||
| return sum( | ||
| period * multiplier | ||
| for period, multiplier in zip( | ||
| map(int, time_strs), [1, 60, 3600, 24 * 3600] | ||
| ) | ||
| ) |
Author
There was a problem hiding this comment.
Function walltime2seconds refactored with the following changes:
- Convert for loop into call to sum() (
sum-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-21
to
+30
| count = dict() | ||
| count = {} | ||
| with open(options.input, 'r') as in_file: | ||
| for line_nr in xrange(options.start): | ||
| for _ in xrange(options.start): | ||
| _ = in_file.readline() | ||
| for line_nr in xrange(options.start, options.end): | ||
| line = in_file.readline().rstrip() | ||
| if not line: | ||
| break | ||
| if options.verbose: | ||
| sys.stderr.write('processing line ' + str(line_nr) + '\n') | ||
| sys.stderr.write(f'processing line {str(line_nr)}' + '\n') |
Author
There was a problem hiding this comment.
Lines 21-30 refactored with the following changes:
- Replace
dict()with{}(dict-literal) - Replace unused for index with underscore (
for-index-underscore) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| word = '' | ||
| for _ in xrange(options.word_length): | ||
| word += random.choice('ABCDE') | ||
| word = ''.join(random.choice('ABCDE') for _ in xrange(options.word_length)) |
Author
There was a problem hiding this comment.
Lines 19-21 refactored with the following changes:
- Use str.join() instead of for loop (
use-join)
| arg_parser.add_argument('out', help='name of the pickle file') | ||
| options = arg_parser.parse_args() | ||
| counter = dict() | ||
| counter = {} |
Author
There was a problem hiding this comment.
Lines 11-11 refactored with the following changes:
- Replace
dict()with{}(dict-literal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!