Closed
Conversation
kylos101
commented
Aug 8, 2023
Contributor
Author
kylos101
left a comment
There was a problem hiding this comment.
Brief self-review
8f90da3 to
a2b54c8
Compare
* buildkit to v0.12.1 * go to 1.20 * `build.go` the signature for `progressui.DisplaySolveStatus` changed * `combiner.go` Architecture and OS were removed from the image spec
c3aa827 to
476277b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.gothe signature forprogressui.DisplaySolveStatuschangedcombiner.goArchitecture and OS were removed from the image specMust
runner binary is too big (> gRPC message size)Could