Fix bugs in create test page #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitakukharchuk
requested review from
Zenater,
alexDose,
gitkoshelew and
visiteur85
nikitakukharchuk
assigned
gitkoshelew,
visiteur85,
nikitakukharchuk,
benyaar,
Zenater and
alexDose
gitkoshelew
approved these changes
Mar 27, 2023
| } | ||
| return null; | ||
| })} | ||
| {fields.length < 4 ? ( |
Owner
There was a problem hiding this comment.
create constant for this number (4)
| const handleNewTopicCancel = () => { | ||
| setShowNewTopicInput(false); | ||
| setNewTopicName(''); | ||
| const getTopicTitles = () => { |
Owner
There was a problem hiding this comment.
looks like place for useMemo
| dispatch(getAllTopics()); | ||
| }, []); | ||
|
|
||
| console.log(topics); |
| const topic = useAppSelector(selectTopic); | ||
| const { t } = useTranslation('Topic'); | ||
| const topics = useAppSelector((state) => state.topics.topicData); | ||
| // const [topics, setTopics] = useState<Topic[]>([]); |
| <Autocomplete | ||
| value={value} | ||
| loading={isLoading} | ||
| filterOptions={(options, params) => { |
Owner
There was a problem hiding this comment.
create memoized callback for this arrow function
| render={() => ( | ||
| <Stack> | ||
| <TextField | ||
| {...params} |
Owner
There was a problem hiding this comment.
do you need all params for TextField?
| options={topics} | ||
| getOptionLabel={(option) => option.title} | ||
| renderOption={(props, option) => <li {...props}>{option.title}</li>} | ||
| renderInput={(params) => ( |
| name={nameControl} | ||
| rules={{ required: true }} | ||
| control={control} | ||
| render={({ field, fieldState: { error } }) => ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bugs in create test page