Conversation
Add Secrets in Custom Steps Validation subsection to the Compiler Validation section of scratchpad/dev.md. Documents the new validateStepsSecrets() check introduced in pkg/workflow/strict_mode_steps_validation.go: behavior in strict vs. non-strict mode, GITHUB_TOKEN exemption, and migration guidance. Bumps dev.md to v5.2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
automation
documentation
pelikhan
deleted the
docs/dev-md-v5.2-secrets-custom-steps-54006272592ed8eb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for the new compiler check introduced in PR #24450 ("Add compiler check disallowing secrets expressions in custom steps").
Changes Made
scratchpad/dev.mdvalidateStepsSecrets()inpkg/workflow/strict_mode_steps_validation.go:secrets.GITHUB_TOKENexemptionscratchpad/dev.mdfrom v5.1 to v5.2Files Modified
scratchpad/dev.md— added 40 lines in the Compiler Validation section; updated version header and document historyValidation
✅ Technical tone throughout (no marketing language)
✅ Code blocks have language tags
✅ No broken links
✅ Consistent with existing subsection structure
Review Notes
pkg/workflow/strict_mode_steps_validation.gosecrets.GITHUB_TOKENexemption behaviour is correctly described