Rename isEmptyDiff → isEmptyFirewallDiff for consistency#24277
Draft
Rename isEmptyDiff → isEmptyFirewallDiff for consistency#24277
isEmptyDiff → isEmptyFirewallDiff for consistency#24277Conversation
9 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d8a40454-719a-4040-8489-4e70e336adb7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename isEmptyDiff to isEmptyFirewallDiff
Rename Apr 3, 2026
isEmptyDiff → isEmptyFirewallDiff for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isEmptyDiffwas ambiguous given sibling functionsisEmptyMCPToolsDiffandisEmptyAuditDiffin the same file — the name didn't communicate which diff type it operated on.Changes
pkg/cli/audit_diff_render.go: Rename function definition and all 4 internal call sitespkg/cli/audit_diff_test.go: Update 2 test call sites to match