Skip to content

[log] Add debug logging to 4 Go files#24180

Merged
pelikhan merged 2 commits intomainfrom
copilot/aw-go-logger-enhancement-fix
Apr 2, 2026
Merged

[log] Add debug logging to 4 Go files#24180
pelikhan merged 2 commits intomainfrom
copilot/aw-go-logger-enhancement-fix

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

The scheduled "Go Logger Enhancement" agentic workflow timed out before completing — it was adding logger.New declarations and debug log calls to Go files that lacked them. This PR implements that work directly.

Changes

Added file-level loggers and meaningful log calls to 4 files with no existing instrumentation:

  • pkg/workflow/compiler_yaml_step_conversion.go (stepConversionLog) — logs step field count on ConvertStepToYAML entry/exit; logs step name in renderStepFromMap
  • pkg/cli/trial_confirmation.go (trialConfirmationLog) — logs workflow count and repo params on entry; host repo existence check result; user confirmation outcome
  • pkg/cli/helpers.go (helpersLog) — logs file path on readSourceRepoFromFile entry, read errors, and successfully extracted repo value
  • pkg/workflow/playwright_tools.go (playwrightToolsLog) — logs tool count returned by GetPlaywrightTools

All loggers follow the pkg:filename naming convention and log arguments are side-effect-free, consistent with project conventions in AGENTS.md. Debug output is zero-overhead when DEBUG is unset or doesn't match the logger namespace.

var stepConversionLog = logger.New("workflow:compiler_yaml_step_conversion")

func ConvertStepToYAML(stepMap map[string]any) (string, error) {
    stepConversionLog.Printf("Converting step to YAML: fields=%d", len(stepMap))
    // ...
    stepConversionLog.Printf("Step conversion complete: %d lines generated", len(lines))
    return result.String(), nil
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw go /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel go /usr/bin/git /ref/tags/v8 qD2WSxZU5 ache/go/1.25.0/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw git 64/pkg/tool/linu--show-toplevel /opt/hostedtoolcache/node/24.14.1/x64/bin/node /tmp�� Value: ${{ github.actor }} 64/pkg/tool/linux_amd64/link /usr/bin/git s/test.md git k git (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name --show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile /usr/bin/git /tmp/go-build232git -trimpath 426556/b430/vet.--show-toplevel git rev-�� --show-toplevel git k/_temp/uv-python-dir/node --show-toplevel 5zZp8GoG3T5YpQfb-### /usr/bin/gh git (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name ut1600656479/001 git /usr/bin/git = get && echo "p/bin/sh = get && echo "p-c /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel 64/pkg/tool/linurev-parse /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha --show-toplevel x_amd64/compile /usr/bin/git ub/workflows GO111MODULE x_amd64/compile git rev-�� --show-toplevel x_amd64/compile /usr/bin/git */*.ts' '**/*.jsgit GO111MODULE ache/go/1.25.0/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha --show-toplevel git /usr/bin/git Gitbranch_with_hgit Gitbranch_with_hrev-parse bin/bash git rev-�� --show-toplevel git ache/node/24.14.1/x64/bin/node y-test.md git x_amd64/link ache/node/24.14.1/x64/bin/node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha z9G5iRhN5 -trimpath /usr/lib/git-core/git-receive-pack -p main -lang=go1.25 git-receive-pack rtcf�� _ioKvjdEQDSK1QrcCe-O/_ioKvjdEQDSK1QrcCe-O tmain.go clusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle -c=4 -nolocalimports -importcfg git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha xterm-color /opt/hostedtoolcTest User /usr/bin/git --package-lock-ogit git /usr/bin/git git rev-�� licyMinIntegrityOnlyrepos_only_without_min-integrity3912193017/001 git /opt/hostedtoolcache/node/24.14.1/x64/bin/node l ache/node/24.14.rev-parse /usr/bin/git node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha ithub/workflows GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD abis 64/pkg/tool/linu-buildtags env plorer.md UIm1LDRzQ k GOINSECURE tants GOMODCACHE ache/go/1.25.0/x-tests (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel x_amd64/link /usr/bin/git -json GO111MODULE x_amd64/compile git rev-�� --show-toplevel x_amd64/compile /usr/bin/git -json GO111MODULE 64/pkg/tool/linu--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel ache/go/1.25.0/x64/pkg/tool/linu-extld=gcc /usr/bin/git ithub/workflows GOPROXY 8117147/b222=> git rev-�� uest|push_to_pull_request_branch)" ache/go/1.25.0/x64/src/reflect/asm_wasm.s /usr/bin/git q6ZV/zBE_EJgyq1cgit sh /opt/hostedtoolc--show-toplevel git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha t0 go ache/node/24.14.1/x64/bin/node m0s GO111MODULE (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha /tmp/go-build224426556/b446/_pkg_.a -trimpath /usr/bin/git -p main -lang=go1.25 git rev-�� --show-toplevel -dwarf=false /usr/bin/git go1.25.0 -c=4 -nolocalimports git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile /usr/bin/git 3545470173 GO111MODULE ache/go/1.25.0/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile /usr/bin/git 8117147/b249/_pkgit tL3Z/CzS-jlvwks0rev-parse 1/x64/bin/node git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -goversion go1.25.0 -c=4 -nolocalimports -importcfg /tmp/go-build2328117147/b211/importcfg -pack env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE sh GOINSECURE GOMOD GOMODCACHE go env on' --ignore-patgo1.25.0 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env on' --ignore-pat-p GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha /tmp/shared-actions-test3204234688 rev-parse /usr/bin/git -json GO111MODULE x_amd64/compile git conf�� --get remote.origin.url /usr/bin/git -json sonschema/annotarev-parse x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha --show-toplevel (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha -test.paniconexit0 -test.v=true /usr/bin/git -test.timeout=10git -test.run=^Test -test.short=true--show-toplevel git remo�� remove origin 426556/b457/vet.cfg 345 lGitbranch_with_rev-parse x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha /tmp/TestGuardPolicyBlockedUsersExpressionCompiledOutput474328685/001 config /usr/bin/git remote.origin.urgit git /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git Onlymin-integritgit git /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq .object.sha GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq .object.sha --show-toplevel git /usr/bin/git efaultBranchFromgit efaultBranchFromrev-parse /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git 3732-50469/test-git git /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq .object.sha licyMinIntegrityOnlymin-integrity_with_explicit_repo2160724858/001 -trimpath /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -p internal/poll -lang=go1.25 /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -o /tmp/go-build2328117147/b204/_pkg_.a -trimpath /usr/bin/git -p net/textproto -lang=go1.25 git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq .object.sha --show-toplevel git /usr/bin/git --show-toplevel git /usr/bin/git git rev-�� --show-toplevel git /usr/lib/git-core/git-remote-https (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq .object.sha licyMinIntegrityOnlymin-integrity_only_defaults_repo4193276007/001 k/gh-aw/gh-aw/pkg/semverutil/semverutil.go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile l crypto/internal/rev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -o /tmp/go-build2328117147/b239/_pkg_.a -trimpath /usr/lib/git-core/git-upload-pack -p golang.org/x/texrev-parse -lang=go1.25 git-upload-pack (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq .object.sha --git-dir git e/git --show-toplevel git /usr/bin/git e/git rev-�� --git-dir git /usr/bin/gh ub/workflows git /home/REDACTED/go/--git-dir gh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a gGZaaWMoY /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE ack GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 --package-lock-only /usr/bin/git run --auto /usr/bin/git git rev-�� hub/workflows git /usr/bin/git --show-toplevel resolved$ /usr/bin/git git (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 ^remote\..*\.gh-resolved$ /usr/bin/git --show-toplevel git /usr/bin/git git rev-�� licyBlockedUsersApprovalLabelsCompiledOutput3468185604/001 git /usr/bin/git --show-toplevel git /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 mLsRemoteWithRealGitbranch_with_hyphen3031223044/001' 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE er GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 /usr/lib/git-core/git /usr/bin/git run --auto (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 4 /usr/bin/git test-logs/run-4 --package-lock-orev-parse /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel git /usr/bin/sed git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE At,event,headBranch,headSha,displayTitle GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/tmp/go-build224426556/b112/vet.cfg env ions-build/main.go 6M-17r9DB 64/pkg/tool/linux_amd64/compile GOINSECURE jsonschema ode-gyp-bin/sh 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 git /usr/bin/git --show-current x_amd64/link /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel resolved$ /usr/bin/git git (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 2 /usr/bin/git test-logs/run-2 --package-lock-oapi /usr/bin/git git rev-�� --show-toplevel git /usr/lib/git-core/git hub/workflows git /usr/bin/tr /usr/lib/git-core/git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE 64/pkg/tool/linu-lang=go1.25 GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu-dwarf=false env g_.a GO111MODULE ache/go/1.25.0/x-nolocalimports GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 --package-lock-only /usr/bin/git -b test-branch /usr/bin/git git rev-�� hub/workflows git /usr/bin/tr --show-toplevel x_amd64/compile /usr/bin/git tr (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 git /usr/bin/git --show-toplevel git /usr/bin/git git rev-�� licyBlockedUsersApprovalLabelsCompiledOutput3468185604/001 git /opt/hostedtoolcache/node/24.14.1/x64/bin/node p.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.prop.pro mLsRemoteWithRearev-parse /usr/bin/git node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 @v1.1.3/base64/base64.go 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a IDX7QLOC1 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 --package-lock-only /usr/bin/git --show-current x_amd64/compile /usr/bin/git git rev-�� --show-toplevel git /usr/bin/sed --show-toplevel resolved$ /usr/bin/git sed (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 ^remote\..*\.gh-resolved$ /usr/bin/git --show-toplevel git /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel git /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a YmuXga5n5 /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE bidirule GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 --package-lock-only /usr/bin/git /tmp/TestHashCongit go /usr/bin/git git rev-�� --show-toplevel git /usr/bin/sed --show-toplevel x_amd64/compile /usr/bin/git sed (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 node /usr/bin/git install --package-lock-orev-parse x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git --show-toplevel git /usr/lib/git-cor--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a c9DDRo4Fb 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 --package-lock-only /usr/bin/git GOMODCACHE x_amd64/asm /usr/bin/git git rev-�� tags/v6 git /usr/bin/sed --show-toplevel x_amd64/compile /usr/bin/git sed (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 --json /usr/bin/git l /usr/lib/git-corinit x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git --show-toplevel git /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path 800841797/001' 800841797/001' 64/bin/go lk-memory gh-aw.wasm -o gh-aw.opt.wasm && \ mv gh-aw.opt.wasm gh-aw.wasm; \ AFTER=$(wc -c < g GOMOD GOMODCACHE go env -json GO111MODULE ode_modules/.bin-lang=go1.25 GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE go env th .prettierigno--detach GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/asm env -json elect.go 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq .object.sha list --json /usr/bin/git --workflow nonexistent-workrev-parse --limit git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/compile /usr/bin/git g_.a GO111MODULE x_amd64/vet git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq .object.sha --show-toplevel git /usr/bin/git --show-toplevel git /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git 92/001/test-frongit git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha -json GO111MODULE 64/pkg/tool/linu-lang=go1.25 GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu-goversion env g_.a GO111MODULE 64/pkg/tool/linu-importcfg GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/scripts/lint_error_messages_test.go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha LsRemoteWithRealGitmain_branch93remote.origin.url LsRemoteWithRealGitmain_branch939383/001' /usr/bin/git --show-toplevel x_amd64/compile /usr/bin/git git bran�� --show-current git /usr/bin/git --show-toplevel x_amd64/compile /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq .object.sha json' --ignore-p-p GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE ic6V4KLZeCDv ules�� -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE r1aaYBq/zQmA82knGL998-sHxALb (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq .object.sha --show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu^remote\..*\.gh-resolved$ /usr/bin/git ithub-script/git/usr/lib/git-core/git -buildtags /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git /tmp/TestGuardPogit config /tmp/go-build224/tmp/TestGuardPolicyMinIntegrityOnlyrepos_only_without_min-integrity2105624243/001 git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq .object.sha --show-toplevel git e/git-receive-pack --show-toplevel ache/go/1.25.0/xconfig /usr/bin/git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha json' --ignore-p-p GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go ules�� -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE s env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq .object.sha json' --ignore-p-p GO111MODULE odules/npm/node_-lang=go1.25 GOINSECURE GOMOD GOMODCACHE go ules�� -json 1.4.1/oauthex/oa-ifaceassert x_amd64/compile GOINSECURE GOMOD GOMODCACHE eDXfSXk/Kh5wiGQgconfig (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq .object.sha ithub-script/git/ref/tags/v8 ache/go/1.25.0/x64/pkg/tool/linux_amd64/link /usr/bin/git ithub/workflows/git -importcfg 426556/b446/impo--bare git rev-�� --show-toplevel 1E03IKOxFokRP/ae41hEPLrBeAPeT5xYG3/XIxFE0XzOROcgEOnrZZT/kdGN-541E03IKOxFokRP /usr/bin/git ry=1 k/gh-aw/gh-aw/pk-C ache/node/24.14./tmp/TestGuardPolicyMinIntegrityOnlyCompiledOutput1600656479/001 git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq .object.sha --show-toplevel git x_amd64/link --show-toplevel ache/go/1.25.0/xrev-parse /usr/bin/git x_amd64/link rev-�� --show-toplevel =my-default /usr/bin/git --show-toplevel ache/go/1.25.0/xrev-parse /usr/bin/git uS/g-zaUtAlG7kMv5Rz_Fi7/Hm9ZH-NSnJlNWim5aeyJ (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha -json .go 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD 694db81f 64/pkg/tool/linux_amd64/compile env g_.a GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha --show-toplevel git /usr/bin/sed --show-toplevel x_amd64/compile /usr/bin/git sed s/-\�� edOutput3696212555/001 git /usr/bin/git --get remote.origin.urpull /usr/bin/git git (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE go env l 2>&1; then \ echo "Running wasm-opt -Oz (size optimization)..."; \ BEFORE=$(wc -c < gh-aw.wa/usr/bin/git mf6mihAfk ache/go/1.25.0/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/x64/pkg/tool/linux_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion --git-dir resolved$ /usr/bin/git git rev-�� --show-toplevel git /usr/bin/bash --git-dir x_amd64/compile /usr/bin/git bash (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion l git /usr/bin/git git comm�� -m initial commit 1/x64/bin/node --show-toplevel /opt/hostedtoolcrev-parse /usr/bin/git 1/x64/bin/node (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo -importcfg /tmp/go-build224426556/b413/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/gitutil/gitutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/gitutil/gitutil_test.go env -json GO111MODULE node GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json act.go 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo /usr/bin/git ository }} -trimpath /usr/bin/git git 1/ --show-toplevel git /usr/bin/git --show-toplevel vU6-LNSBhKeow5V6-atomic 1/x64/bin/node git (http block)
  • https://api.github.com/repos/owner/repo/contents/file.md
    • Triggering command: /tmp/go-build224426556/b396/cli.test /tmp/go-build224426556/b396/cli.test -test.testlogfile=/tmp/go-build224426556/b396/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true -nolocalimports -importcfg /tmp/go-build2328117147/b176/importcfg -pack env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /tmp/go-build3228291657/b396/cli.test /tmp/go-build3228291657/b396/cli.test -test.testlogfile=/tmp/go-build3228291657/b396/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true runs/20260402-22git -trimpath /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile /usr/bin/git ithub-script/gitgit -trimpath /usr/bin/git git (http block)
    • Triggering command: /tmp/go-build4011271853/b373/cli.test /tmp/go-build4011271853/b373/cli.test -test.testlogfile=/tmp/go-build4011271853/b373/testlog.txt -test.paniconexit0 -test.timeout=5m0s rev-�� --show-toplevel git /usr/bin/git --show-toplevel x_amd64/compile /usr/bin/git git rev-�� HEAD git /usr/bin/git --show-toplevel x_amd64/compile /usr/bin/git git (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name go1.25.0 -c=4 -nolocalimports -importcfg /tmp/go-build224426556/b405/importcfg -pack /tmp/go-build224426556/b405/_testmain.go env -json cpgodebug/mcpgodebug.go 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name --show-toplevel 426556/b413/importcfg /usr/bin/git k/gh-aw/gh-aw/pkgit k/gh-aw/gh-aw/pkrev-parse /usr/bin/git git rev-�� --show-toplevel git ache/node/24.14.1/x64/bin/npm --show-toplevel l /usr/bin/infocmp ache/node/24.14.1/x64/bin/npm (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name 2910940565/.github/workflows git /usr/bin/git --show-toplevel x_amd64/compile /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel 64/pkg/tool/linuconfig /usr/bin/git git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 2, 2026 that may be closed by this pull request
Add file-level debug loggers and meaningful log calls to 4 Go files
that previously had no logging:

- pkg/workflow/compiler_yaml_step_conversion.go: log step field count
  on ConvertStepToYAML entry/exit and step name in renderStepFromMap
- pkg/cli/trial_confirmation.go: log workflow count, repo params,
  host repo existence check result, and user confirmation outcome
- pkg/cli/helpers.go: log file path on readSourceRepoFromFile entry,
  read failures, and successfully extracted source repo value
- pkg/workflow/playwright_tools.go: log count of Playwright tools
  returned by GetPlaywrightTools

All loggers follow the 'pkg:filename' naming convention from AGENTS.md.
Logger arguments have no side effects per project guidelines.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ab42ea9c-29b9-448e-9cbd-46b687a0c3f9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Go Logger Enhancement workflow failure [log] Add debug logging to 4 Go files Apr 2, 2026
Copilot AI requested a review from pelikhan April 2, 2026 22:44
@pelikhan pelikhan marked this pull request as ready for review April 2, 2026 23:25
Copilot AI review requested due to automatic review settings April 2, 2026 23:25
@pelikhan pelikhan merged commit 9ee731e into main Apr 2, 2026
@pelikhan pelikhan deleted the copilot/aw-go-logger-enhancement-fix branch April 2, 2026 23:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds debug-level instrumentation to previously uninstrumented areas to improve observability when DEBUG is enabled.

Changes:

  • Introduces file-scoped logger.New(...) instances in 4 Go files following existing namespace patterns.
  • Adds debug Print/Printf calls to trace key execution points (step conversion/rendering, trial confirmation flow, repo extraction, Playwright tool list size).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pkg/workflow/playwright_tools.go Adds a workflow-scoped logger and logs the number of Playwright tools returned.
pkg/workflow/compiler_yaml_step_conversion.go Adds a workflow-scoped logger and logs step conversion entry/exit plus step rendering details.
pkg/cli/trial_confirmation.go Adds a CLI-scoped logger and logs trial confirmation flow checkpoints and outcomes.
pkg/cli/helpers.go Adds a CLI-scoped logger and logs file read + extracted repo during frontmatter parsing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

helpersLog.Printf("Reading source repo from file: %s", path)
content, err := os.ReadFile(path)
if err != nil {
helpersLog.Printf("Failed to read file: %s", err)
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printf uses %s with err (an error), which will produce a formatting mismatch when debug logging is enabled (e.g. %!s(...)). Use %v (or err.Error() with %s) to match established usage elsewhere (e.g. pkg/workflow/compiler_orchestrator_frontmatter.go:39).

Suggested change
helpersLog.Printf("Failed to read file: %s", err)
helpersLog.Printf("Failed to read file: %v", err)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Go Logger Enhancement failed

3 participants