Implement conclusion job step improvements#24063
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6d1145a5-2333-44e4-af4f-a370f4f6ecff Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 2, 2026 11:13
View session
Collaborator
|
@copilot implement improvements |
…ndle_create_pr_error, serialize messages config once Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7f826d13-c024-4d8e-9d04-636d29a5ad71 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Implemented in cc1e739. Three concrete improvements:
All 179 workflows recompiled; all tests and linters pass. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Analysis: conclusion job step redundancy and concurrency issues
Implement conclusion job step improvements
Apr 2, 2026
Contributor
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
Contributor
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
Contributor
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Contributor
|
Commit pushed:
|
Contributor
|
🤖 Smoke Test Results — run §23899414681
Overall: ✅ PASS PR author:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Smoke test review of PR #24063 — conclusion job step consolidation looks solid. The two-step noop sequence is cleanly merged, dead code removed, and the serializeMessagesConfig deduplication reduces potential drift. Minor nit on variable shadowing noted inline.
📰 BREAKING: Report filed by Smoke Copilot
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the generated “conclusion” job across compiled workflows by merging redundant no-op handling steps, removing a dead error-handling step, and reducing duplicated computation of safe-output message configuration.
Changes:
- Merge the former
noop.cjs+handle_noop_message.cjssequence into a single no-op processing step that loads agent output directly and setsnoop_message. - Remove an always-no-op
handle_create_pr_errorstep from the conclusion job generation path. - Compute
GH_AW_SAFE_OUTPUT_MESSAGESserialization once and reuse it where needed.
Reviewed changes
Copilot reviewed 177 out of 177 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/js.go | Removes unused getNoOpScript() stub after no-op script embedding removal. |
| .github/workflows/workflow-skill-extractor.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/workflow-normalizer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/workflow-health-manager.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/workflow-generator.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/weekly-issue-summary.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/video-analyzer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/typist.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/test-project-url-default.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/test-dispatcher.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/terminal-stylist.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/super-linter.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/sub-issue-closer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/step-name-alignment.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/static-analysis-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-workflow-call.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-workflow-call-with-inputs.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-update-cross-repo-pr.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-test-tools.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-temporary-id.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-service-ports.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-gemini.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-copilot.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-copilot-arm.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-codex.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-claude.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-call-workflow.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-agent-scoped-approved.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-agent-public-none.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-agent-public-approved.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-agent-all-none.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/smoke-agent-all-merged.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/sergo.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/semantic-function-refactor.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/security-review.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/security-compliance.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/scout.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/schema-consistency-checker.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/safe-output-health.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/research.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/repository-quality-improver.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/repo-tree-map.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/repo-audit-analyzer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/release.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/python-data-charts.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/pr-triage-agent.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/portfolio-analyst.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/plan.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/pdf-summary.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/org-health-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/notion-issue-summary.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/mergefest.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/mcp-inspector.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/lockfile-stats.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/issue-triage-agent.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/issue-monster.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/issue-arborist.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/grumpy-reviewer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/gpclean.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/go-pattern-detector.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/go-fan.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/github-remote-mcp-auth-test.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/firewall-escape.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/example-workflow-analyzer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/duplicate-code-detector.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/draft-pr-cleanup.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/docs-noob-tester.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/discussion-task-miner.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/dev.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/dev-hawk.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/dependabot-go-checker.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/dependabot-burner.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/delight.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/deep-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-team-evolution-insights.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-semgrep-scan.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-security-red-team.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-secrets-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-safe-outputs-conformance.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-repo-chronicle.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-regulatory.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-performance-summary.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-observability-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-news.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-multi-device-docs-tester.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-issues-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-integrity-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-function-namer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-firewall-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-file-diet.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-fact.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-copilot-token-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-compiler-quality.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-code-metrics.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-cli-performance.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-choice-test.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/daily-assign-issue-to-user.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/craft.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/copilot-session-insights.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/copilot-agent-analysis.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/contribution-check.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/constraint-solving-potd.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/commit-changes-analyzer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/cli-version-checker.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/cli-consistency-checker.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/changeset.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/breaking-change-checker.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/brave.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/bot-detection.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/blog-auditor.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/auto-triage-issues.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/audit-workflows.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/artifacts-summary.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/archie.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/ai-moderator.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/agentic-observability-kit.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars (including disabling issue reporting). |
| .github/workflows/agent-persona-explorer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
| .github/workflows/agent-performance-analyzer.lock.yml | Updates conclusion job to run handle_noop_message.cjs directly and removes the redundant follow-up step; adds required env vars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conclusion job generated several redundant or dead steps across all compiled workflows. This PR implements the following improvements:
Merged noop steps
The former two-step "Process No-Op Messages" (
noop.cjs) + "Handle No-Op Message" (handle_noop_message.cjs) sequence is now a single "Process No-Op Messages" step.handle_noop_message.cjsnow loads agent output directly, writes the step summary, setscore.setOutput("noop_message", …), and posts to the no-op runs issue — eliminating the cross-stepGH_AW_NOOP_MESSAGEenv var dependency. The unusedgetNoOpScript()stub was also removed fromjs.go.Removed dead
handle_create_pr_errorstepCREATE_PR_ERROR_MESSAGEwas never set in the step's env block so the step always exited immediately on the firstif (!errorMessage)check. The step has been removed fromnotify_comment.go, eliminating it from all 39 affected compiled workflows.GH_AW_SAFE_OUTPUT_MESSAGESserialized onceserializeMessagesConfig()was previously called twice inbuildConclusionJob— once foragentFailureEnvVarsand once forcustomEnvVars. It is now computed once and reused in both places.Remaining known issues (not yet addressed)
GH_AW_WORKFLOW_NAME,GH_AW_TRACKER_ID,GH_AW_RUN_URL,GH_AW_AGENT_CONCLUSIONstill appear in multiple stepenv:blocks; lifting them to job-levelenv:requires updates to several tests that assert on step-level YAML.gh-aw-conclusion-{workflow_id}group withcancel-in-progress: falseserializes all conclusion jobs for a workflow; no per-trigger discriminator is applied by default.Changeset
handle_create_pr_errorstep, and reusing serialized safe output message configuration for conclusion env generation.