-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Support spec v1.11.0 — OpenTelemetry OTLP tracing configuration (§4.1.3.6) #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f4ded51
Initial plan
Copilot c1325b7
feat: implement spec v1.11.0 OpenTelemetry OTLP tracing configuration
Copilot 8599e6e
test: improve ParentContext and serviceName defaults tests with more …
Copilot 9cbcfd9
Update internal/config/validation.go
lpcox bf3719d
Update internal/config/schema/mcp-gateway-config.schema.json
lpcox 48821a5
Update internal/config/schema/mcp-gateway-config.schema.json
lpcox 071d382
fix: address review feedback for OpenTelemetry config
lpcox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments state tracing Headers/TraceID/SpanID “support ${VAR} variable expansion”, but TOML config loading doesn’t appear to perform ${VAR} expansion for these fields (stdin JSON does via ExpandRawJSONVariables). Consider clarifying the comment to match actual behavior, or implementing variable expansion for TOML-loaded tracing config so the documented behavior is true.