fix: resolve duplicate test declarations in server package

[lpcox]

Problem

make lint fails on main with:

vet: internal/server/session_test.go:144:6: newMinimalUnifiedServer redeclared in this block

Two recently merged branches both added declarations that conflict:

• session_test.go: newMinimalUnifiedServer(t) and TestRequireSession
• ensure_guard_initialized_test.go: newMinimalUnifiedServer(cfg) (different signature)
• unified_test.go: TestRequireSession

Fix

Rename the session_test.go declarations to avoid conflicts:

• newMinimalUnifiedServer → newMinimalUnifiedServerForSessionTest
• TestRequireSession → TestRequireSession_SessionManagement

All tests pass with make agent-finished.

[Copilot]

Pull request overview

Resolves go vet/lint failures in the internal/server test package caused by duplicate top-level test/helper declarations introduced by recent merges, by renaming the conflicting symbols in session_test.go.

Changes:

• Renamed newMinimalUnifiedServer(t) to newMinimalUnifiedServerForSessionTest(t) in session_test.go.
• Renamed TestRequireSession to TestRequireSession_SessionManagement to avoid colliding with another test of the same name.

Comments suppressed due to low confidence (1)

internal/server/session_test.go:234

• The doc comment above this test still says TestRequireSession, but the test function was renamed to TestRequireSession_SessionManagement. Please update the comment to avoid confusion and keep go doc output accurate.

// TestRequireSession verifies that requireSession auto-creates a new Session
// the first time a session ID is seen and reuses the same Session on subsequent calls.
func TestRequireSession_SessionManagement(t *testing.T) {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.