Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes related to dark mode functionality by removing the custom ThemeContext, ThemeToggleButton, and ColorStyles, and by reverting _app.tsx to a previous state that uses the ThemeProvider from @primer/react-brand.
- Removed custom dark mode context and provider
- Removed dark mode toggle button and related styling
- Cleaned up imports from components using dark mode specifics
Reviewed Changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pages/_app.tsx | Reverted to using ThemeProvider from @primer/react-brand and removed custom theme functionality |
| context/ThemeContext.tsx | Entirely removed custom dark mode context |
| components/SDGFilter.tsx | Removed use of ColorStyles |
| components/LanguageFilter.tsx | Removed use of ColorStyles and consolidated Select props |
| components/Header/ThemeToggleButton.tsx | Removed dark mode toggle button component |
| components/Header/Header.tsx | Removed dark mode toggle component; manually set dark mode attribute |
| components/ColorStyles.tsx | Removed custom ColorStyles file |
Files not reviewed (3)
- components/Header/Header.module.scss: Language not supported
- package.json: Language not supported
- styles/globals.scss: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #246