C# 14: [TEST ONLY] Test for nameof generic type.
#21100
Merged
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive test for the C# 14 feature that allows nameof to be applied to generic types, including unconstructed generic types. The test confirms that the extractor and QL library handle this feature correctly out of the box.
- Adds a new test directory for
nameofoperator testing - Tests various uses of
nameofincluding parameters, methods, types, and generic types - Specifically validates the new capability to use
nameof(List<>)for unconstructed generic types
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| csharp/ql/test/library-tests/nameof/NameOf.cs | C# source file with 6 test cases for nameof, including the new unconstructed generic type usage |
| csharp/ql/test/library-tests/nameof/nameof.ql | QL query to extract and test NameOfExpr instances |
| csharp/ql/test/library-tests/nameof/nameof.expected | Expected results showing all 6 nameof expressions and their accessed elements |
| csharp/ql/test/library-tests/nameof/PrintAst.qlref | Reference to shared PrintAst query for AST validation |
| csharp/ql/test/library-tests/nameof/PrintAst.expected | Expected AST output showing the structure of all test cases |
| csharp/ql/test/library-tests/nameof/options | Extractor configuration options for the test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| class Program | ||
| { | ||
| public void M(int x) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add a test for
nameofapplied to a generic type (previously this only worked for constructed types). This works out of the box in the extractor and QL library.