Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 5, 2026

In this PR, we update the generated .NET runtime models by applying the model generator to a .NET 10 version of dotnet/runtime.

A couple of notes

  • DCA looks good. No changes to results or performance.
  • A couple of tests needed to be updated as the model below is no longer generated (it doesn't affect any results)
    • ["System.Collections.Generic", "List+Enumerator", False, "get_Current", "()", "", "Argument[this].Property[System.Collections.Generic.List`1+Enumerator.Current]", "ReturnValue", "value", "dfc-generated"]

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",47,12241,54,5
+    System,"``System.*``, ``System``",47,12491,59,5
-    Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.AspNetCore.Components``, ``Microsoft.AspNetCore.Http``, ``Microsoft.AspNetCore.Mvc``, ``Microsoft.AspNetCore.WebUtilities``, ``Microsoft.CSharp``, ``Microsoft.Data.SqlClient``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.DotNet.PlatformAbstractions``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.JSInterop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``NHibernate``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",60,2257,162,4
+    Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.AspNetCore.Components``, ``Microsoft.AspNetCore.Http``, ``Microsoft.AspNetCore.Mvc``, ``Microsoft.AspNetCore.WebUtilities``, ``Microsoft.CSharp``, ``Microsoft.Data.SqlClient``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.DotNet.PlatformAbstractions``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.JSInterop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``NHibernate``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",60,2406,162,4
-    Totals,,107,14505,410,9
+    Totals,,107,14904,415,9
  • Changes to framework-coverage-csharp.csv:
- ILCompiler,,,121,,,,,,,,,,,,,,,,,,,77,44
+ ILCompiler,,,132,,,,,,,,,,,,,,,,,,,81,51
- ILLink.RoslynAnalyzer,,,107,,,,,,,,,,,,,,,,,,,31,76
+ ILLink.RoslynAnalyzer,,,110,,,,,,,,,,,,,,,,,,,31,79
- ILLink.Shared,,,37,,,,,,,,,,,,,,,,,,,9,28
+ ILLink.Shared,,,45,,,,,,,,,,,,,,,,,,,17,28
- Internal.IL,,,54,,,,,,,,,,,,,,,,,,,28,26
+ Internal.IL,,,68,,,,,,,,,,,,,,,,,,,41,27
- Internal.TypeSystem,,,343,,,,,,,,,,,,,,,,,,,197,146
+ Internal.TypeSystem,,,365,,,,,,,,,,,,,,,,,,,216,149
- Microsoft.Extensions.Caching.Memory,,,37,,,,,,,,,,,,,,,,,,,5,32
+ Microsoft.Extensions.Caching.Memory,,,35,,,,,,,,,,,,,,,,,,,5,30
- Microsoft.Extensions.Configuration,,3,118,,,,,,,,,,,,,3,,,,,,39,79
+ Microsoft.Extensions.Configuration,,3,133,,,,,,,,,,,,,3,,,,,,45,88
- Microsoft.Extensions.DependencyInjection,,,209,,,,,,,,,,,,,,,,,,,15,194
+ Microsoft.Extensions.DependencyInjection,,,187,,,,,,,,,,,,,,,,,,,22,165
- Microsoft.Extensions.DependencyModel,,1,57,,,,,,,,,,,,,1,,,,,,13,44
+ Microsoft.Extensions.DependencyModel,,1,58,,,,,,,,,,,,,1,,,,,,13,45
- Microsoft.Extensions.FileSystemGlobbing,,,37,,,,,,,,,,,,,,,,,,,13,24
+ Microsoft.Extensions.FileSystemGlobbing,,,37,,,,,,,,,,,,,,,,,,,14,23
- Microsoft.Extensions.Hosting,,,61,,,,,,,,,,,,,,,,,,,29,32
+ Microsoft.Extensions.Hosting,,,60,,,,,,,,,,,,,,,,,,,28,32
- Microsoft.Extensions.Logging,,,107,,,,,,,,,,,,,,,,,,,26,81
+ Microsoft.Extensions.Logging,,,110,,,,,,,,,,,,,,,,,,,29,81
- Microsoft.Extensions.Options,,,174,,,,,,,,,,,,,,,,,,,48,126
+ Microsoft.Extensions.Options,,,175,,,,,,,,,,,,,,,,,,,41,134
- Microsoft.Interop,,,216,,,,,,,,,,,,,,,,,,,71,145
+ Microsoft.Interop,,,220,,,,,,,,,,,,,,,,,,,74,146
- Mono.Linker,,,278,,,,,,,,,,,,,,,,,,,127,151
+ Mono.Linker,,,370,,,,,,,,,,,,,,,,,,,218,152
- System,54,47,12241,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,6003,6238
+ System,59,47,12491,,6,5,12,,,4,1,,31,2,,6,15,17,4,3,,6378,6113

@michaelnebel michaelnebel force-pushed the net10/generatedmodels branch from 128d9fc to 2e20804 Compare January 6, 2026 09:21
@michaelnebel michaelnebel marked this pull request as ready for review January 6, 2026 09:40
@michaelnebel michaelnebel requested a review from a team as a code owner January 6, 2026 09:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated .NET runtime models by applying the model generator to a .NET 10 version of dotnet/runtime. The update removes one auto-generated model for List<T>+Enumerator.get_Current that is no longer produced by the generator, and adds numerous new models for .NET 10 APIs.

Key Changes

  • Removed auto-generated model: List<T>+Enumerator.get_Current
  • Updated test expected files to reflect line number changes from the removed model
  • Added many new taint flow and summary models for .NET 10 APIs across multiple namespaces

Reviewed changes

Copilot reviewed 1 out of 145 changed files in this pull request and generated no comments.

Show a summary per file
File Description
csharp/ql/test/library-tests/dataflow/collections/CollectionTaintFlow.expected Updated line numbers due to removed model; MaD references adjusted from indices 17-30 to 17-29
csharp/ql/test/library-tests/dataflow/collections/CollectionDataFlow.expected Updated line numbers due to removed model; MaD references adjusted from indices 14-26 to 14-25
csharp/ql/lib/ext/generated/System.model.yml Added 200+ new models for .NET 10 APIs including BinaryData, MemoryExtensions, String, Type, Uri, etc.
csharp/ql/lib/ext/generated/System.Xml.model.yml Added models for XmlDictionaryReader, XmlDocument, XmlNamespaceManager, XmlNode, etc.; removed some outdated models
csharp/ql/lib/ext/generated/System.Xml.Xsl.model.yml Added models for XsltArgumentList and XsltException
csharp/ql/lib/ext/generated/System.Xml.Xsl.Runtime.model.yml Added models for XmlILIndex, XmlQueryContext, XmlQueryOutput, XsltLibrary
csharp/ql/lib/ext/generated/System.Xml.XPath.model.yml Added comprehensive models for XPathException serialization
csharp/ql/lib/ext/generated/System.Xml.Serialization.model.yml Added models for CodeIdentifiers, XmlSchemaExporter, XmlSchemaImporter, XmlSerializer, etc.
csharp/ql/lib/ext/generated/System.Xml.Schema.model.yml Added models for XmlSchemaCollection, XmlSchemaDatatype, XmlSchemaValidator
csharp/ql/lib/ext/generated/System.Xml.Resolvers.model.yml Added models for XmlPreloadedResolver.Add methods
csharp/ql/lib/ext/generated/System.Xml.Linq.model.yml Moved some models from neutral to summary category
csharp/ql/lib/ext/generated/System.Threading.model.yml Added models for new NamedWaitHandleOptions parameter overloads
csharp/ql/lib/ext/generated/System.Threading.Tasks.model.yml Added Task.WhenAll for ReadOnlySpan, moved some neutral models to summary
csharp/ql/lib/ext/generated/System.Text.Json.Serialization.model.yml Added ReferenceResolver.GetReference model
csharp/ql/lib/ext/generated/System.Text.Json.Serialization.Metadata.model.yml Moved JsonTypeInfoResolver.Combine to neutral
csharp/ql/lib/ext/generated/System.Runtime.model.yml Added DependentHandle constructor models

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelnebel michaelnebel merged commit ff1ec47 into github:main Jan 6, 2026
29 checks passed
@michaelnebel michaelnebel deleted the net10/generatedmodels branch January 6, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants