Skip to content

C#: Narrow provenance printing in tests. #21094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelnebel wants to merge 2 commits into from
Closed

C#: Narrow provenance printing in tests. #21094

michaelnebel wants to merge 2 commits into from
+68,338 −71,112

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 5, 2026

In this PR we narrow the printing of provenance for models to either manual or generated.
The current printing is inaccurate as provenances for models are collapsed by callable. This means, if a callable has both a heuristic and dataflow generated model, then both models will be printed for each provenance.

@michaelnebel michaelnebel requested a review from hvitved January 5, 2026 12:51
@michaelnebel michaelnebel marked this pull request as ready for review January 5, 2026 12:51
@michaelnebel michaelnebel requested review from a team as code owners January 5, 2026 12:51
Copilot AI review requested due to automatic review settings January 5, 2026 12:51
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Jan 5, 2026
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies provenance rendering in test output by narrowing the classification to either "manual" or "generated". The change addresses inaccurate provenance printing that occurred when callables had multiple provenance types, which were previously being collapsed and duplicated.

Key Changes:

  • Replaced complex provenance rendering logic with a simplified binary classification based on whether a model is manual or generated

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hvitved
Copy link
Contributor

hvitved commented Jan 5, 2026

The current printing is inaccurate as provenances for models are collapsed by callable. This means, if a callable has both a heuristic and dataflow generated model, then both models will be printed for each provenance.

FWIW, with #21051 they will no longer be collapsed.

@michaelnebel
Copy link
Contributor Author

michaelnebel commented Jan 5, 2026

The current printing is inaccurate as provenances for models are collapsed by callable. This means, if a callable has both a heuristic and dataflow generated model, then both models will be printed for each provenance.

FWIW, with #21051 they will no longer be collapsed.

Ok, then I will just close this PR then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hvitved hvitved Awaiting requested review from hvitved

Assignees

No one assigned

Labels

C# DataFlow Library no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved