Skip to content

Conversation

@hverhelst hverhelst requested a review from Copilot June 25, 2025 11:47
@hverhelst hverhelst self-assigned this Jun 25, 2025
@hverhelst hverhelst added the enhancement New feature or request label Jun 25, 2025
@hverhelst hverhelst added this to the v25.06.0 milestone Jun 25, 2025

This comment was marked as outdated.

@hverhelst hverhelst requested a review from Copilot June 25, 2025 11:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the TFT examples by adding benchmark executables, refining mass‐assembly output, and improving XML boundary‐condition formatting.

  • Introduced two new benchmark programs for cylinder and pillow TFT cases.
  • Updated mass assembly in the static_shell_XML.cpp solver to use direct RHS output.
  • Expanded single‐line <Function> tags in several XML PDE files to explicit <c> entries.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
unittests/gsStaticSolver_test.cpp Removed stray whitespace
src/gsStaticSolvers/gsStaticNewton.hpp Initialized m_dofs from system matrix row count
src/gsStaticSolvers/gsStaticDR.hpp Set m_residualIni on first residual computation
solvers/static_shell_XML.cpp Switched to assembleMass(true) and updated output path
filedata/pde/*.xml Reformatted zero‐value <Function> tags into <c> blocks
benchmarks/benchmark_cylinder_DC.cpp Added full wrinkling benchmark implementation
benchmarks/benchmark_Pillow.cpp Added pillow benchmark tweaks and new command‐line flags
Comments suppressed due to low confidence (2)

benchmarks/benchmark_cylinder_DC.cpp:2

  • The @file comment references benchmark_TensionWrinkling.cpp but the file is named benchmark_cylinder_DC.cpp. Please update the comment to match the file name for clarity.
/** @file benchmark_TensionWrinkling.cpp

solvers/static_shell_XML.cpp:332

  • The variable sep is not defined in this scope, which will cause a compilation error. Consider replacing it with a literal path separator (e.g., "/" or gsFileManager::separator()) or ensure sep is defined.
      gsWrite(mp_def,dirname + sep + "deformed");

hverhelst and others added 4 commits July 11, 2025 09:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hverhelst hverhelst merged commit 4a61d91 into main Jul 11, 2025
3 checks passed
@hverhelst hverhelst deleted the torsion branch July 11, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants