-
Notifications
You must be signed in to change notification settings - Fork 4
Improve examples for TFT #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
only add solution in `gsStaticComposite` if converged
add docs static optimizer change cmakelists targets
…sidual==0 in first iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the TFT examples by adding benchmark executables, refining mass‐assembly output, and improving XML boundary‐condition formatting.
- Introduced two new benchmark programs for cylinder and pillow TFT cases.
- Updated mass assembly in the
static_shell_XML.cppsolver to use direct RHS output. - Expanded single‐line
<Function>tags in several XML PDE files to explicit<c>entries.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| unittests/gsStaticSolver_test.cpp | Removed stray whitespace |
| src/gsStaticSolvers/gsStaticNewton.hpp | Initialized m_dofs from system matrix row count |
| src/gsStaticSolvers/gsStaticDR.hpp | Set m_residualIni on first residual computation |
| solvers/static_shell_XML.cpp | Switched to assembleMass(true) and updated output path |
| filedata/pde/*.xml | Reformatted zero‐value <Function> tags into <c> blocks |
| benchmarks/benchmark_cylinder_DC.cpp | Added full wrinkling benchmark implementation |
| benchmarks/benchmark_Pillow.cpp | Added pillow benchmark tweaks and new command‐line flags |
Comments suppressed due to low confidence (2)
benchmarks/benchmark_cylinder_DC.cpp:2
- The
@filecomment referencesbenchmark_TensionWrinkling.cppbut the file is namedbenchmark_cylinder_DC.cpp. Please update the comment to match the file name for clarity.
/** @file benchmark_TensionWrinkling.cpp
solvers/static_shell_XML.cpp:332
- The variable
sepis not defined in this scope, which will cause a compilation error. Consider replacing it with a literal path separator (e.g., "/" orgsFileManager::separator()) or ensuresepis defined.
gsWrite(mp_def,dirname + sep + "deformed");
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add benchmarks for the paper