Separate out the core service to be able to use from search

[tomasz-grobelny]

Let's break my changes into some logical parts. This one does not bring any functional benefits, but allows the service to be used in other parts of nextcloud (in particular fulltextsearch) and separates creating response (controller) from actual logic of getting the metadata from file (service).

[tomasz-grobelny]

I have created new PR on files_fulltextsearch side (nextcloud/files_fulltextsearch#19) so that indexing is not affected if metadata app is disabled.

[tomasz-grobelny]

Please have a look at this updated pull request - it uses new extensibility mechanism provided in fulltextsearch and files_fulltextsearch (minor change related to subtags on their side is still needed - I've sent mail to maintainer). This means that he indexing logic is now in metadata application, not the files_fulltextsearch.

As for search side it is not yet clear if changes are required - my next thing to investigate.

[gino0631]

OK, I'll take a look.

[tomasz-grobelny]

Now the search by tags should work. You can use it like this: "* meta:tag=Rose". You need the first asterisk as it seems to require as least one non-option word to search by (even if it is an asterisk).

[tomasz-grobelny]

Any thoughts? Note that this change works only with latest fts code and this PR: nextcloud/fulltextsearch_elasticsearch#39 (minor bugfix).

[tomasz-grobelny]

Ping.

[gino0631]

Any thoughts? Note that this change works only with latest fts code and this PR: nextcloud/fulltextsearch_elasticsearch#39 (minor bugfix).

Does it mean it is required to have the "Full text search - Elasticsearch" app installed?

[ArtificialOwl]

@tomasz-grobelny I came to the same conclusion, thanks for this PR.