fix(gzip): prevent gzip header flush when compression is disabled#138
Open
the729 wants to merge 1 commit intogin-contrib:masterfrom
Open
fix(gzip): prevent gzip header flush when compression is disabled#138the729 wants to merge 1 commit intogin-contrib:masterfrom
the729 wants to merge 1 commit intogin-contrib:masterfrom
Conversation
Add check for shouldCompress flag before flushing gzip writer to avoid unnecessary header writes. Also add test cases for 400 status with and without compression header. fix gin-contrib#137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for shouldCompress flag before flushing gzip writer to avoid unnecessary header writes. Also add test cases for 400 status with and without compression header.
fix #137