Skip to content

Allow wrk2 to start without specifying the rate parameter #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ol-damirm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow wrk2 to start without specifying the rate parameter #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/wrk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ static void usage() {
" -v, --version Print version details \n"
" -R, --rate <T> work rate (throughput) \n"
" in requests/sec (total) \n"
" [Required Parameter] \n"
" [UINT64_MAX by default] \n"
" \n"
" \n"
" Numeric arguments may include a SI unit (1k, 1M, 1G)\n"
Expand Down Expand Up @@ -160,8 +160,14 @@ int main(int argc, char **argv) {

char *time = format_time_s(cfg.duration);
printf("Running %s test @ %s\n", time, url);
printf(" %"PRIu64" threads and %"PRIu64" connections\n",
cfg.threads, cfg.connections);
if (cfg.rate == UINT64_MAX) {
printf(" %"PRIu64" threads and %"PRIu64" connections\n",
cfg.threads, cfg.connections);
} else {
printf(" %"PRIu64" threads and %"PRIu64" connections "
"with desired rate %"PRIu64"\n",
cfg.threads, cfg.connections, cfg.rate);
}

uint64_t start = time_us();
uint64_t complete = 0;
Expand Down Expand Up @@ -776,11 +782,8 @@ static int parse_args(struct config *cfg, char **url, struct http_parser_url *pa
return -1;
}

if (cfg->rate == 0) {
fprintf(stderr,
"Throughput MUST be specified with the --rate or -R option\n");
return -1;
}
if (cfg->rate == 0)
cfg->rate = UINT64_MAX;

*url = argv[optind];
*header = NULL;
Expand Down