physlean migration exportation a rg85 #3
Merged
+51
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gift-framework
commented
Jan 16, 2026
gift-framework
commented
- Sort G2 imports alphabetically in PhysLean.lean
- Add docstrings for notation definitions in Exterior.lean (ε and ∧')
- Remove unused arguments in E8Lattice.lean:
- norm_sq_even_of_half_int_even_sum: remove _hsum parameter
- E8_basis_generates: use term-mode to avoid unused variable
- reflect_preserves_lattice: remove _hα_root parameter
- Sort G2 imports alphabetically in PhysLean.lean - Add docstrings for notation definitions in Exterior.lean (ε and ∧') - Remove unused arguments in E8Lattice.lean: - norm_sq_even_of_half_int_even_sum: remove _hsum parameter - E8_basis_generates: use term-mode to avoid unused variable - reflect_preserves_lattice: remove _hα_root parameter
- Add @[pseudo] to all theorems using native_decide (34 total) - Fix E8_basis_generates to remove unused membership argument The @[pseudo] attribute marks theorems that depend on Lean.ofReduceBool (used by native_decide), as required by PhysLean's sorry_lint checker.
The @[pseudo] attribute is defined in PhysLean.Meta.Linters.Sorry, not in Mathlib. Add the necessary import to all G2 files that use it. Also rename unused variable v to _v in E8_basis_generates.
gift-framework
deleted the
claude/physlean-migration-exploration-aRG85
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.