Skip to content

Hotfix: Add docker build target if run on mac #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camposeddie merged 2 commits into from
Mar 4, 2026
Merged

Hotfix: Add docker build target if run on mac #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5900b4
Add docker build target if run on mac
camposeddie Feb 13, 2026
f8d0655
Update build_push_docker script to be able to run within science work…
camposeddie Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions build_push_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,15 @@ if [[ -z "${STACK_PREFIX}" ]]; then
read -rp 'STACK_PREFIX: ' STACK_PREFIX
fi

AWS_ACCOUNT_ID=$(get_account_id $AWS_PROFILE)
AWS_ACCOUNT_ID=$(get_account_id)

if [[ $(uname -m) == arm64* ]]; then
Comment thread
camposeddie marked this conversation as resolved.
docker_build="docker buildx build --load --platform linux/amd64 -t"
else
docker_build="docker build -t"
fi

docker build -t ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com/$REPO_NAME .
${docker_build} ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com/$REPO_NAME .
check_exit

create_ecr_repo_or_skip $AWS_ACCOUNT_ID $STACK_PREFIX
Expand Down
3 changes: 1 addition & 2 deletions common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ function create_ecr_repo_or_skip() {
}

function get_account_id() {
# $1 AWS_PROFILE
echo $(aws sts get-caller-identity --query Account --profile $1 | tr -d '"')
echo $(aws sts get-caller-identity --query Account $ADD_PROFILE | tr -d '"')
}

function stop_mdx_task() {
Expand Down