allow phantom to reply to conversations its part of naturally#33
Open
rossja wants to merge 2 commits intoghostwright:mainfrom
Open
allow phantom to reply to conversations its part of naturally#33rossja wants to merge 2 commits intoghostwright:mainfrom
rossja wants to merge 2 commits intoghostwright:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This allows phantom to reply to conversations/threads it's part of without needing to be mentioned directlly.
Important Note: You also need to enable the
message.channels(and optionallymessage.groups) event subscription in the Slack app's Event Subscriptions settings for this to work.Why
It's annoying having to mention it by name every time you want to follow up in a thread. This fixes it so the conversations flow more naturally.
How I Tested
Patched, ran in container. Tested in Slack. Phantom replies to messages in threads. I posted random chatter to the main slack channel Phantom is in, and it did not respond unless mentioned (even just saying its name did not elicit a response, this fix is only applied to threads).
Checklist
bun test)bun run lint)bun run typecheck).envfiles included