WIP: Regenerate palette on OSC 10/11#10911
Open
jake-stewart wants to merge 1 commit intoghostty-org:mainfrom
Open
WIP: Regenerate palette on OSC 10/11#10911jake-stewart wants to merge 1 commit intoghostty-org:mainfrom
jake-stewart wants to merge 1 commit intoghostty-org:mainfrom
Conversation
Contributor
Author
|
FWIW, here is my script I used to test this:
All the while I have The color256.py is just a script which helps visualise the palette. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintains a working copy of the palette mask (so that palettes set with OSC4 are not overwritten) which is restored to the original config mask when the palette is reset.
I wonder if we should regenerate when some base16 colors change? (The remaining 6 corners of the color cube)
A concern is that changing a theme could cause the theme to generate up to 8 times. This can be optimized down to 3 if you combine sequences. I guess that's negligible really. Generating the palette is efficient.