gtk: +new-window now respects --working-directory and -e#10809
Open
jcollie wants to merge 3 commits intoghostty-org:mainfrom
Open
gtk: +new-window now respects --working-directory and -e#10809jcollie wants to merge 3 commits intoghostty-org:mainfrom
+new-window now respects --working-directory and -e#10809jcollie wants to merge 3 commits intoghostty-org:mainfrom
Conversation
00-kat
added
os/linux
gui
|
If it doesn't take too much effort, may I request support for just one more flag: |
Member
Author
|
@WieeRd Unfortunately that's impossible since that property is a per-display-connection setting. Since Ghostty is a single process and has a single connection to the display manager we can't change it after the process starts up. |
jcollie
force-pushed
the
gtk-new-window-ipc
branch
from
4694b64 to
e6cbcf8
Compare
Fixes: ghostty-org#8862 Fixes: ghostty-org#10716 This adds the machinery to pass configuration settings received over DBus down to the GObject Surface so that that configuration information can be used to override some settings from the current "live" config when creating a new window. Currently it's only possible to override `--working-directory` and `--command`. `-e` on the `ghostty +new-window` CLI works as well. Adding more overridable settings is possible, but being able to fully override any possible setting would better be served with a major revamp of how Ghostty handles configs, which I is way out of scope at the moment.
jcollie
force-pushed
the
gtk-new-window-ipc
branch
from
e6cbcf8 to
0052e59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8862
Fixes: #10716
This adds the machinery to pass configuration settings received over DBus down to the GObject Surface so that that configuration information can be used to override some settings from the current "live" config when creating a new window. Currently it's only possible to override
--working-directory,--command, and--title.-eon theghostty +new-windowCLI works as well.Adding more overridable settings is possible, but being able to fully override any possible setting would better be served with a major revamp of how Ghostty handles configs, which I is way out of scope at the moment.