macos: fix text editing shortcuts in modal sheet text fields#10806
Open
peilingjiang wants to merge 1 commit intoghostty-org:mainfrom
Open
macos: fix text editing shortcuts in modal sheet text fields#10806peilingjiang wants to merge 1 commit intoghostty-org:mainfrom
peilingjiang wants to merge 1 commit intoghostty-org:mainfrom
Conversation
Route Cmd+A/C/X/V (select all, copy, cut, paste) to the text system when a modal sheet or dialog is active, preventing terminal and menu shortcuts from consuming them. Adds a UI test for the Change Tab Title sheet covering this fix. Ref: ghostty-org#10623
mitchellh
requested changes
Feb 18, 2026
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
I don't love hardcoding these like this. I'd prefer if there was a way to check the current responder chain first. Then we wouldn't have to hardcode anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Cmd+A/C/X/V to the text system when a modal sheet or dialog is active, preventing terminal or menu shortcuts from consuming them.
Fix #10749
AI Use Note: The tests were initially created in full by Claude Opus 4.6. The fix was reviewed and improved with its help as well. All code is read by a human.