Closed
Conversation
`jsaddle` by default re-exports a large number of modules from `ghcjs-base` when compiling with the JS backend. This PR is the first step in extending `jsaddle` to support WASM JS FFI calls in `jsaddle-wasm`. This is in contrast to the current solution of relying on the `jsaddle` command protocol internally (as seen in `jsaddle-warp`), to route commands via a `TQueue`. By using the WASM JS FFI performance should increase. This PR splits up the existing code into `src-js` and `src-wasm` (JS code remains unchanged). Per @amesgen, not all modules are required to be ported, just a subset (as demonstrated in the cabal file). - [x] Adds `flake.nix` that references `miso` multi-compiler support - [x] Adds a Github workflow CI for compilation w/ JS / WASM 9.12.2 backends - [ ] Port existing JS FFI logic to WASM FFI.
6 tasks
Contributor
Author
|
closing in favor of dmjio/miso#1306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsaddleby default re-exports a large number of modules fromghcjs-basewhen compiling with the JS backend. This PR is the first step in extendingjsaddleto support WASM JS FFI calls injsaddle-wasm.This is in contrast to the current solution of relying on the
jsaddlecommand protocol internally (as seen injsaddle-warp), to route commands via aTQueue.By using the WASM JS FFI performance should increase.
This PR splits up the existing code into
src-jsandsrc-wasm(JS code remains unchanged). Per @amesgen, not all modules are required to be ported, just a subset (as demonstrated in the cabal file).flake.nixthat referencesmisomulti-compiler support