Skip to content

Chapter 2, Exercise 5: Fixed two bugs which could cause indefinite waits when no correct guess was provided#7

Open
aldiyen wants to merge 1 commit intoghanithan:mainfrom
aldiyen:bug/issue6-infinite-loop-waits
Open

Chapter 2, Exercise 5: Fixed two bugs which could cause indefinite waits when no correct guess was provided#7
aldiyen wants to merge 1 commit intoghanithan:mainfrom
aldiyen:bug/issue6-infinite-loop-waits

Conversation

@aldiyen
Copy link

@aldiyen aldiyen commented Nov 19, 2025

Fixes issue #6

Pull Request

Description

Brief description of the changes in this PR.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New exercise (adds a new learning exercise)
  • Exercise improvement (enhances existing exercise)
  • Feature (new functionality for platform)
  • Documentation (updates to docs, README, etc.)
  • Refactoring (code cleanup, no functional changes)

Exercise Changes (if applicable)

  • Chapter: 2
  • Exercise ID: 5
  • Type: Bug Fix
  • Difficulty: n/a

Testing Checklist

  • Exercise compiles without warnings
  • All tests pass (cargo test)
  • Clippy passes (cargo clippy)
  • Exercise is completable by target audience
  • Hints are helpful without giving away solution
  • Solution explanation is clear and educational
  • Rust Book references are accurate and relevant

Quality Checklist

  • Code follows project style guidelines
  • Comments are clear and helpful
  • Error messages are beginner-friendly
  • Exercise metadata is complete and accurate
  • No hardcoded solutions or shortcuts

Documentation Updates

  • Updated exercise list in README
  • Added/updated hints.md file
  • Updated chapter progress tracking
  • Added Rust Book references

Breaking Changes

Does this PR introduce any breaking changes?

  • Yes (describe below)
  • No

If yes, describe the breaking changes and migration path:

Additional Notes

Any additional context, screenshots, or information relevant to this PR.

@ghanithan
Copy link
Owner

Hi @aldiyen,
Good catch! Users would get stuck in infinite loops during testing. Thanks for fixing both cases!

@ghanithan ghanithan self-requested a review December 21, 2025 11:13
@ghanithan
Copy link
Owner

@aldiyen Could you please sign your commits? Thanks!

@aldiyen aldiyen force-pushed the bug/issue6-infinite-loop-waits branch from e1dffbf to 94db004 Compare December 21, 2025 18:51
@aldiyen
Copy link
Author

aldiyen commented Dec 21, 2025

@aldiyen Could you please sign your commits? Thanks!

Oops, thought I had done that. Fixed.

@aldiyen aldiyen force-pushed the bug/issue6-infinite-loop-waits branch from 94db004 to 3513569 Compare January 20, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments