Optimize performance by removing internal generics #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Benchmarks/Readme.md # Tests/AsyncChannelsTests/AsyncChannelTests.swift # media/swift-vs-go.png # media/vs-async-alg.png
gh123man
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the hot path by removing generics from the internal channel implementation.
Most of the existing performance overhead was caused by runtime generics due to lack of specialization - especially for buffered channel benchmarks.
This PR improves the benchmarks across the board, and in some cases
2x+ improvements are observed (especially for buffered channel benchmarks).Using a single concrete type internally prevents the compiler form having to resolve generics for the hot path. As a result, I was able to use
Dequeinstead ofLinkedListwhich provided further improvements.