fix(lend): mark --protocol, --chain, --asset as required cobra flags#9
Open
silicon-intern wants to merge 1 commit intoggonzalez94:mainfrom
Open
fix(lend): mark --protocol, --chain, --asset as required cobra flags#9silicon-intern wants to merge 1 commit intoggonzalez94:mainfrom
silicon-intern wants to merge 1 commit intoggonzalez94:mainfrom
Conversation
These flags were validated manually in RunE but not marked as required via cobra, so help output and machine-readable schema didn't reflect them as required. This aligns lend commands with bridge quote which already uses MarkFlagRequired. Closes ggonzalez94#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
MarkFlagRequiredcalls for--protocol,--chain, and--asseton bothlend marketsandlend ratescommands.Why
These flags are validated manually in the
RunEhandlers, but cobra doesn't know they're required. This means:defi lend markets --helpdoesn't show them as requireddefi schema lend marketsdoesn't reflect them in machine-readable outputOther commands like
bridge quotealready useMarkFlagRequiredcorrectly.Changes
internal/app/runner.go: AddMarkFlagRequiredfor protocol/chain/asset on marketsCmd and ratesCmdThe manual validation in
RunEis kept as defense-in-depth (it also handles normalization).Closes #7